rotten news relay - rocksolid.nodes.help - Re: spaces inserted when changing subject

Subject: spaces inserted when changing subject
From: Marco Moock
Newsgroups: rocksolid.nodes.help
Organization: A noiseless patient Spider
Date: Wed, 6 Nov 2024 16:10 UTC

Path: eternal-september.org!news.eternal-september.org!.POSTED!not-for-mail
From: mm+usenet-es@dorfdsl.de (Marco Moock)
Newsgroups: rocksolid.nodes.help
Subject: spaces inserted when changing subject
Date: Wed, 6 Nov 2024 17:10:58 +0100
Organization: A noiseless patient Spider
Lines: 19
Message-ID: <vgg4ei$26e09$1@dont-email.me>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Injection-Date: Wed, 06 Nov 2024 17:10:59 +0100 (CET)
Injection-Info: dont-email.me; posting-host="65ac100ed45fe0b3b384d61510669eb4";
logging-data="2308105"; mail-complaints-to="abuse@eternal-september.org"; posting-account="U2FsdGVkX1+56lnz4UkYmJ5p6KZmJnIs"
Cancel-Lock: sha1:vKB0ba8tEsylXmGlyXplaTz1HHc=

View all headers

Hello!

One of my users reported that a space is inserted when changing the
subject.
https://pi-dach.dorfdsl.de/rocksolid/article-flat.php?id=209&group=rocksolid.shared.test#209

Betreff 3 (war: Betreff 2? )

According to him, it happens when replying to a post with changed
subject.

If you need more info, please tell me.

--
kind regards
Marco

Send spam to 1730909215muell@stinkedores.dorfdsl.de

Subject: Re: spaces inserted when changing subject
From: Retro Guy
Newsgroups: rocksolid.nodes.help
Organization: Rocksolid Light
Date: Wed, 6 Nov 2024 16:20 UTC
References: 1

View all headers

On Wed, 6 Nov 2024 17:10:58 +0100, Marco Moock wrote:

> Hello!
>
> One of my users reported that a space is inserted when changing the
> subject.
> https://pi-dach.dorfdsl.de/rocksolid/article-flat.php?id=209&group=rocksolid.shared.test#209
>
> Betreff 3 (war: Betreff 2? )
>
> According to him, it happens when replying to a post with changed
> subject.
>
> If you need more info, please tell me.

I think I see. Are they added at the end of the Subject?

If so, I should be able to trim that, just let me know if that is the
specific place you're seeing spaces added.

Subject: Re: spaces inserted when changing subject
From: Retro Guy
Newsgroups: rocksolid.nodes.help
Organization: Rocksolid Light development site
Date: Wed, 6 Nov 2024 16:37 UTC
References: 1 2

Path: eternal-september.org!news.eternal-september.org!feeder2.eternal-september.org!i2pn.org!i2pn2.org!.POSTED!not-for-mail
From: retro.guy@rocksolidbbs.com (Retro Guy)
Newsgroups: rocksolid.nodes.help
Subject: Re: spaces inserted when changing subject
Date: Wed, 6 Nov 2024 16:37:06 +0000
Organization: Rocksolid Light development site
Message-ID: <0b61c7ec2420f93fe1bb66604ecef6d5@example.com>
References: <vgg4ei$26e09$1@dont-email.me> <c231a294be5371cfa1581d8e04e6907e$1@novabbs.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Injection-Info: i2pn2.org;
logging-data="1239872"; mail-complaints-to="usenet@i2pn2.org";
posting-account="D0b4VQC1DRDMD6KZpq3aPScvEpIhqvuykTqXjXAFAlQ";
User-Agent: Rocksolid Light
X-Spam-Checker-Version: SpamAssassin 4.0.0
X-Rslight-Site: $2y$10$ZZlak3vxOExiAz1dQLXGBuf.bUcxpZD/.2YbYJ/uqIyxJfGTlhf4W
X-Face: .&YR-G(w(DZ$$,}%k=]*5*!p'=(anr"IT`wZG'2VWdfl\r)l[42u7JH`n(JUQ*e5*A|XCDf ?&\X&uwkl38"CYX3O8m}C8E4p'%N$2#kSTVzx{Ly|DjLT\Vk7NE}NQ(VC$Yq]i:7|z[.9iv^g>*8_B H0=hZt'[%)4kG|
X-Rslight-Posting-User: 57ddb8f1a4a05e45f53fcfd180d236ac23f6dd4e

View all headers

On Wed, 6 Nov 2024 16:20:25 +0000, Retro Guy wrote:

> On Wed, 6 Nov 2024 17:10:58 +0100, Marco Moock wrote:
>
>> Hello!
>>
>> One of my users reported that a space is inserted when changing the
>> subject.
>> https://pi-dach.dorfdsl.de/rocksolid/article-flat.php?id=209&group=rocksolid.shared.test#209
>>
>> Betreff 3 (war: Betreff 2? )
>>
>> According to him, it happens when replying to a post with changed
>> subject.
>>
>> If you need more info, please tell me.
>
> I think I see. Are they added at the end of the Subject?
>
> If so, I should be able to trim that, just let me know if that is the
> specific place you're seeing spaces added.

Take a look in post.php (in <webdir>/rocksolid. Find line 64, or near
there:

// Check some header strings for bad characters
$newsgroups = sanitize_header($newsgroups);
$subject = sanitize_header($subject);
$email = sanitize_header($email);

change line:
$subject = sanitize_header($subject);

to:
$subject = trim(sanitize_header($subject));

and see if that fixes the issue.

--
Retro Guy

Subject: Re: spaces inserted when changing subject
From: Retro Guy
Newsgroups: rocksolid.nodes.help
Organization: Rocksolid Light
Date: Thu, 7 Nov 2024 13:39 UTC
References: 1 2 3

Path: eternal-september.org!news.eternal-september.org!feeder2.eternal-september.org!i2pn.org!i2pn2.org!.POSTED!not-for-mail
From: retroguy@novabbs.com (Retro Guy)
Newsgroups: rocksolid.nodes.help
Subject: Re: spaces inserted when changing subject
Date: Thu, 7 Nov 2024 13:39:48 +0000
Organization: Rocksolid Light
Message-ID: <7b957ce7c199d3e5a5e7ae453587e8b1@www.novabbs.org>
References: <vgg4ei$26e09$1@dont-email.me> <c231a294be5371cfa1581d8e04e6907e$1@novabbs.org> <0b61c7ec2420f93fe1bb66604ecef6d5@example.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Injection-Info: i2pn2.org;
logging-data="1372986"; mail-complaints-to="usenet@i2pn2.org";
posting-account="HNchV9coSOli+kkOHciCZlGs2VaRn7Emh38jWV1k174";
User-Agent: Rocksolid Light
X-Rslight-Posting-User: 28547bffeec402cc2e544e2f8e28cc9329f66434
X-Rslight-Site: $2y$10$lZkcSxmdNxFqX1/8gqQe4Oxbw34.CK7N.qWdfbnVpcN4BqKMr.kmu
X-Face: .&YR-G(w(DZ$$,}%k=]*5*!p'=(anr"IT`wZG'2VWdfl\r)l[42u7JH`n(JUQ*e5*A|XCDf ?&\X&uwkl38"CYX3O8m}C8E4p'%N$2#kSTVzx{Ly|DjLT\Vk7NE}NQ(VC$Yq]i:7|z[.9iv^g>*8_B H0=hZt'[%)4kG|
X-Spam-Checker-Version: SpamAssassin 4.0.0

View all headers

On Wed, 6 Nov 2024 16:37:06 +0000, Retro Guy wrote:

> On Wed, 6 Nov 2024 16:20:25 +0000, Retro Guy wrote:
>
>> On Wed, 6 Nov 2024 17:10:58 +0100, Marco Moock wrote:
>>
>>> Hello!
>>>
>>> One of my users reported that a space is inserted when changing the
>>> subject.
>>> https://pi-dach.dorfdsl.de/rocksolid/article-flat.php?id=209&group=rocksolid.shared.test#209
>>>
>>> Betreff 3 (war: Betreff 2? )
>>>
>>> According to him, it happens when replying to a post with changed
>>> subject.
>>>
>>> If you need more info, please tell me.
>>
>> I think I see. Are they added at the end of the Subject?
>>
>> If so, I should be able to trim that, just let me know if that is the
>> specific place you're seeing spaces added.
>
> Take a look in post.php (in <webdir>/rocksolid. Find line 64, or near
> there:
>
> // Check some header strings for bad characters
> $newsgroups = sanitize_header($newsgroups);
> $subject = sanitize_header($subject);
> $email = sanitize_header($email);
>
> change line:
> $subject = sanitize_header($subject);
>
> to:
> $subject = trim(sanitize_header($subject));
>
> and see if that fixes the issue.

I have pushed this change to devel.

--
Retro Guy

Subject: Re: spaces inserted when changing subject
From: Ulf_Kutzner
Newsgroups: rocksolid.nodes.help
Organization: DorfDSL, send complaints to mm+rslight@dorfdsl.de
Date: Mon, 25 Nov 2024 10:00 UTC
References: 1 2 3 4

Path: eternal-september.org!news.eternal-september.org!feeder2.eternal-september.org!i2pn.org!i2pn2.org!.POSTED!not-for-mail
From: Ulf.Kutzner@web.de (Ulf_Kutzner)
Newsgroups: rocksolid.nodes.help
Subject: Re: spaces inserted when changing subject
Date: Mon, 25 Nov 2024 10:00:33 +0000
Organization: DorfDSL, send complaints to mm+rslight@dorfdsl.de
Message-ID: <761467a60ed7f0200610a7437de1a874@pi-dach.dorfdsl.de>
References: <vgg4ei$26e09$1@dont-email.me> <c231a294be5371cfa1581d8e04e6907e$1@novabbs.org> <0b61c7ec2420f93fe1bb66604ecef6d5@example.com> <7b957ce7c199d3e5a5e7ae453587e8b1@www.novabbs.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Injection-Info: i2pn2.org;
logging-data="4045213"; mail-complaints-to="usenet@i2pn2.org";
posting-account="gbALAKgiVsPoILVQGeepRWZAL4EHOIYc7GfQ6SFHhYg";
User-Agent: Rocksolid Light
X-Rslight-Posting-User: 023030fb3f32f6d38e62347e48578f02c445ac50
X-Spam-Checker-Version: SpamAssassin 4.0.0
X-Rslight-Site: $2y$10$Vxw7yXyUSE53T/xmXIrEAu6weU3BdVLBPsDVwvZQPu.K4s9THEctq

View all headers

On Thu, 7 Nov 2024 13:39:48 +0000, Retro Guy wrote:

> On Wed, 6 Nov 2024 16:37:06 +0000, Retro Guy wrote:
>
>> On Wed, 6 Nov 2024 16:20:25 +0000, Retro Guy wrote:
>>
>>> On Wed, 6 Nov 2024 17:10:58 +0100, Marco Moock wrote:
>>>
>>>> Hello!
>>>>
>>>> One of my users reported that a space is inserted when changing the
>>>> subject.
>>>> https://pi-dach.dorfdsl.de/rocksolid/article-flat.php?id=209&group=rocksolid.shared.test#209
>>>>
>>>> Betreff 3 (war: Betreff 2? )
>>>>
>>>> According to him, it happens when replying to a post with changed
>>>> subject.
>>>>
>>>> If you need more info, please tell me.
>>>
>>> I think I see. Are they added at the end of the Subject?
>>>
>>> If so, I should be able to trim that, just let me know if that is the
>>> specific place you're seeing spaces added.
>>
>> Take a look in post.php (in <webdir>/rocksolid. Find line 64, or near
>> there:
>>
>> // Check some header strings for bad characters
>> $newsgroups = sanitize_header($newsgroups);
>> $subject = sanitize_header($subject);
>> $email = sanitize_header($email);
>>
>> change line:
>> $subject = sanitize_header($subject);
>>
>> to:
>> $subject = trim(sanitize_header($subject));
>>
>> and see if that fixes the issue.
>
> I have pushed this change to devel.

Problem found again today while answering to
https://pi-dach.dorfdsl.de/rocksolid/article-flat.php?id=209&group=de.etc.bahn.stadtverkehr#209

Had been resolved, has re-appered again?

The space has, of course, been inserted before
but should be deleted while deleting the old
subject (the part in brackets which the space precedes).

Regards, ULF

Subject: Re: spaces inserted when changing subject
From: Retro Guy
Newsgroups: rocksolid.nodes.help
Organization: Rocksolid Light
Date: Mon, 25 Nov 2024 11:01 UTC
References: 1 2 3 4 5

Path: eternal-september.org!news.eternal-september.org!feeder2.eternal-september.org!i2pn.org!i2pn2.org!.POSTED!not-for-mail
From: retroguy@novabbs.com (Retro Guy)
Newsgroups: rocksolid.nodes.help
Subject: Re: spaces inserted when changing subject
Date: Mon, 25 Nov 2024 11:01:15 +0000
Organization: Rocksolid Light
Message-ID: <8c002ebc3ed7e50f8e128762c02d06cd@www.novabbs.org>
References: <vgg4ei$26e09$1@dont-email.me> <c231a294be5371cfa1581d8e04e6907e$1@novabbs.org> <0b61c7ec2420f93fe1bb66604ecef6d5@example.com> <7b957ce7c199d3e5a5e7ae453587e8b1@www.novabbs.org> <761467a60ed7f0200610a7437de1a874@pi-dach.dorfdsl.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Injection-Info: i2pn2.org;
logging-data="4053151"; mail-complaints-to="usenet@i2pn2.org";
posting-account="HNchV9coSOli+kkOHciCZlGs2VaRn7Emh38jWV1k174";
User-Agent: Rocksolid Light
X-Rslight-Site: $2y$10$lx1yuf163r4/OYQG9qR.3uDjqPpDT6wC/jXmIkjdLGcT2LBhtanlG
X-Rslight-Posting-User: 28547bffeec402cc2e544e2f8e28cc9329f66434
X-Face: .&YR-G(w(DZ$$,}%k=]*5*!p'=(anr"IT`wZG'2VWdfl\r)l[42u7JH`n(JUQ*e5*A|XCDf ?&\X&uwkl38"CYX3O8m}C8E4p'%N$2#kSTVzx{Ly|DjLT\Vk7NE}NQ(VC$Yq]i:7|z[.9iv^g>*8_B H0=hZt'[%)4kG|
X-Spam-Checker-Version: SpamAssassin 4.0.0

View all headers

On Mon, 25 Nov 2024 10:00:33 +0000, Ulf_Kutzner wrote:

> On Thu, 7 Nov 2024 13:39:48 +0000, Retro Guy wrote:
>
>> On Wed, 6 Nov 2024 16:37:06 +0000, Retro Guy wrote:
>>
>>> On Wed, 6 Nov 2024 16:20:25 +0000, Retro Guy wrote:
>>>
>>>> On Wed, 6 Nov 2024 17:10:58 +0100, Marco Moock wrote:
>>>>
>>>>> Hello!
>>>>>
>>>>> One of my users reported that a space is inserted when changing the
>>>>> subject.
>>>>> https://pi-dach.dorfdsl.de/rocksolid/article-flat.php?id=209&group=rocksolid.shared.test#209
>>>>>
>>>>> Betreff 3 (war: Betreff 2? )
>>>>>
>>>>> According to him, it happens when replying to a post with changed
>>>>> subject.
>>>>>
>>>>> If you need more info, please tell me.
>>>>
>>>> I think I see. Are they added at the end of the Subject?
>>>>
>>>> If so, I should be able to trim that, just let me know if that is the
>>>> specific place you're seeing spaces added.
>>>
>>> Take a look in post.php (in <webdir>/rocksolid. Find line 64, or near
>>> there:
>>>
>>> // Check some header strings for bad characters
>>> $newsgroups = sanitize_header($newsgroups);
>>> $subject = sanitize_header($subject);
>>> $email = sanitize_header($email);
>>>
>>> change line:
>>> $subject = sanitize_header($subject);
>>>
>>> to:
>>> $subject = trim(sanitize_header($subject));
>>>
>>> and see if that fixes the issue.
>>
>> I have pushed this change to devel.
>
> Problem found again today while answering to
> https://pi-dach.dorfdsl.de/rocksolid/article-flat.php?id=209&group=de.etc.bahn.stadtverkehr#209
>
> Had been resolved, has re-appered again?
>
> The space has, of course, been inserted before
> but should be deleted while deleting the old
> subject (the part in brackets which the space precedes).

Is this the article where you are seeing the space:
https://pi-dach.dorfdsl.de/rocksolid/article-flat.php?id=210&group=de.etc.bahn.stadtverkehr#210

If so, I'm not seeing it. I checked the code and the "fix" is still
there, at least in git. I viewed on the site you reference and do not
see the space.

What am I missing?

--
Retro Guy

Path: eternal-september.org!news.eternal-september.org!feeder2.eternal-september.org!i2pn.org!i2pn2.org!.POSTED!not-for-mail
From: Ulf.Kutzner@web.de (Ulf_Kutzner)
Newsgroups: rocksolid.nodes.help
Subject: Re: spaces inserted when changing subject
Date: Mon, 25 Nov 2024 11:25:57 +0000
Organization: DorfDSL, send complaints to mm+rslight@dorfdsl.de
Message-ID: <c6900d272a28fa4c496f8627e3d557c0@pi-dach.dorfdsl.de>
References: <vgg4ei$26e09$1@dont-email.me> <c231a294be5371cfa1581d8e04e6907e$1@novabbs.org> <0b61c7ec2420f93fe1bb66604ecef6d5@example.com> <7b957ce7c199d3e5a5e7ae453587e8b1@www.novabbs.org> <761467a60ed7f0200610a7437de1a874@pi-dach.dorfdsl.de> <8c002ebc3ed7e50f8e128762c02d06cd@www.novabbs.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Injection-Info: i2pn2.org;
logging-data="4057700"; mail-complaints-to="usenet@i2pn2.org";
posting-account="gbALAKgiVsPoILVQGeepRWZAL4EHOIYc7GfQ6SFHhYg";
User-Agent: Rocksolid Light
X-Rslight-Posting-User: 023030fb3f32f6d38e62347e48578f02c445ac50
X-Spam-Checker-Version: SpamAssassin 4.0.0
X-Rslight-Site: $2y$10$9NkRK0qxE7OJ1ZolhOlFuuGDxFqkjrt7xvHFPwoooinZIKvapkx.G

View all headers

On Mon, 25 Nov 2024 11:01:15 +0000, Retro Guy wrote:

> On Mon, 25 Nov 2024 10:00:33 +0000, Ulf_Kutzner wrote:
>
>> On Thu, 7 Nov 2024 13:39:48 +0000, Retro Guy wrote:
>>
>>> On Wed, 6 Nov 2024 16:37:06 +0000, Retro Guy wrote:
>>>
>>>> On Wed, 6 Nov 2024 16:20:25 +0000, Retro Guy wrote:
>>>>
>>>>> On Wed, 6 Nov 2024 17:10:58 +0100, Marco Moock wrote:
>>>>>
>>>>>> Hello!
>>>>>>
>>>>>> One of my users reported that a space is inserted when changing the
>>>>>> subject.
>>>>>> https://pi-dach.dorfdsl.de/rocksolid/article-flat.php?id=209&group=rocksolid.shared.test#209
>>>>>>
>>>>>> Betreff 3 (war: Betreff 2? )
>>>>>>
>>>>>> According to him, it happens when replying to a post with changed
>>>>>> subject.
>>>>>>
>>>>>> If you need more info, please tell me.
>>>>>
>>>>> I think I see. Are they added at the end of the Subject?
>>>>>
>>>>> If so, I should be able to trim that, just let me know if that is the
>>>>> specific place you're seeing spaces added.
>>>>
>>>> Take a look in post.php (in <webdir>/rocksolid. Find line 64, or near
>>>> there:
>>>>
>>>> // Check some header strings for bad characters
>>>> $newsgroups = sanitize_header($newsgroups);
>>>> $subject = sanitize_header($subject);
>>>> $email = sanitize_header($email);
>>>>
>>>> change line:
>>>> $subject = sanitize_header($subject);
>>>>
>>>> to:
>>>> $subject = trim(sanitize_header($subject));
>>>>
>>>> and see if that fixes the issue.
>>>
>>> I have pushed this change to devel.
>>
>> Problem found again today while answering to
>> https://pi-dach.dorfdsl.de/rocksolid/article-flat.php?id=209&group=de.etc.bahn.stadtverkehr#209
>>
>> Had been resolved, has re-appered again?
>>
>> The space has, of course, been inserted before
>> but should be deleted while deleting the old
>> subject (the part in brackets which the space precedes).
>
> Is this the article where you are seeing the space:
> https://pi-dach.dorfdsl.de/rocksolid/article-flat.php?id=210&group=de.etc.bahn.stadtverkehr#210
>
> If so, I'm not seeing it. I checked the code and the "fix" is still
> there, at least in git. I viewed on the site you reference and do not
> see the space.
>
> What am I missing?

What happens if you try to reply to

Re: Strassenbahnzuege (war: Brueckeneinsturz)
From: Ignatios Souvatzis
Date: Sun, 24 Nov 2024 22:27 00100
Newsgroups: de.etc.bahn.stadtverkehr

and while changing the subject again,
put the current subject into brackets again?

Regards, ULF

Subject: Re: spaces inserted when changing subject
From: Retro Guy
Newsgroups: rocksolid.nodes.help
Organization: i2pn2 (i2pn.org)
Date: Mon, 25 Nov 2024 11:49 UTC
References: 1 2 3 4 5 6 7

Path: eternal-september.org!news.eternal-september.org!feeder2.eternal-september.org!i2pn.org!i2pn2.org!.POSTED!not-for-mail
From: retroguy@novabbs.org (Retro Guy)
Newsgroups: rocksolid.nodes.help
Subject: Re: spaces inserted when changing subject
Date: Mon, 25 Nov 2024 11:49:39 -0000 (UTC)
Organization: i2pn2 (i2pn.org)
Message-ID: <d90bbe71548cbcfd2e681c92773f46c2fa80032d@i2pn2.org>
References: <vgg4ei$26e09$1@dont-email.me> <c231a294be5371cfa1581d8e04e6907e$1@novabbs.org> <0b61c7ec2420f93fe1bb66604ecef6d5@example.com> <7b957ce7c199d3e5a5e7ae453587e8b1@www.novabbs.org> <761467a60ed7f0200610a7437de1a874@pi-dach.dorfdsl.de> <8c002ebc3ed7e50f8e128762c02d06cd@www.novabbs.org> <c6900d272a28fa4c496f8627e3d557c0@pi-dach.dorfdsl.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Injection-Date: Mon, 25 Nov 2024 11:49:39 -0000 (UTC)
Injection-Info: i2pn2.org;
logging-data="4059514"; mail-complaints-to="usenet@i2pn2.org";
posting-account="Gg8gAsZLN5FnWZrpbmz42d6ib2C2ewfwYI9Q557pxrY";
User-Agent: XPN/1.2.6 (Street Spirit ; Windows)
X-Spam-Checker-Version: SpamAssassin 4.0.0

View all headers

Ulf_Kutzner wrote:

> On Mon, 25 Nov 2024 11:01:15 +0000, Retro Guy wrote:
>
>> On Mon, 25 Nov 2024 10:00:33 +0000, Ulf_Kutzner wrote:
>>
>>> On Thu, 7 Nov 2024 13:39:48 +0000, Retro Guy wrote:
>>>
>>>> On Wed, 6 Nov 2024 16:37:06 +0000, Retro Guy wrote:
>>>>
>>>>> On Wed, 6 Nov 2024 16:20:25 +0000, Retro Guy wrote:
>>>>>
>>>>>> On Wed, 6 Nov 2024 17:10:58 +0100, Marco Moock wrote:
>>>>>>
>>>>>>> Hello!
>>>>>>>
>>>>>>> One of my users reported that a space is inserted when changing the
>>>>>>> subject.
>>>>>>> https://pi-dach.dorfdsl.de/rocksolid/article-flat.php?id=209&group=rocksolid.shared.test#209
>>>>>>>
>>>>>>> Betreff 3 (war: Betreff 2? )
>>>>>>>
>>>>>>> According to him, it happens when replying to a post with changed
>>>>>>> subject.
>>>>>>>
>>>>>>> If you need more info, please tell me.
>>>>>>
>>>>>> I think I see. Are they added at the end of the Subject?
>>>>>>
>>>>>> If so, I should be able to trim that, just let me know if that is the
>>>>>> specific place you're seeing spaces added.
>>>>>
>>>>> Take a look in post.php (in <webdir>/rocksolid. Find line 64, or near
>>>>> there:
>>>>>
>>>>> // Check some header strings for bad characters
>>>>> $newsgroups = sanitize_header($newsgroups);
>>>>> $subject = sanitize_header($subject);
>>>>> $email = sanitize_header($email);
>>>>>
>>>>> change line:
>>>>> $subject = sanitize_header($subject);
>>>>>
>>>>> to:
>>>>> $subject = trim(sanitize_header($subject));
>>>>>
>>>>> and see if that fixes the issue.
>>>>
>>>> I have pushed this change to devel.
>>>
>>> Problem found again today while answering to
>>> https://pi-dach.dorfdsl.de/rocksolid/article-flat.php?id=209&group=de.etc.bahn.stadtverkehr#209
>>>
>>> Had been resolved, has re-appered again?
>>>
>>> The space has, of course, been inserted before
>>> but should be deleted while deleting the old
>>> subject (the part in brackets which the space precedes).
>>
>> Is this the article where you are seeing the space:
>> https://pi-dach.dorfdsl.de/rocksolid/article-flat.php?id=210&group=de.etc.bahn.stadtverkehr#210
>>
>> If so, I'm not seeing it. I checked the code and the "fix" is still
>> there, at least in git. I viewed on the site you reference and do not
>> see the space.
>>
>> What am I missing?
>
> What happens if you try to reply to
>
> Re: Strassenbahnzuege (war: Brueckeneinsturz)
> From: Ignatios Souvatzis
> Date: Sun, 24 Nov 2024 22:27 00100
> Newsgroups: de.etc.bahn.stadtverkehr
>
> and while changing the subject again,
> put the current subject into brackets again?

Ok, I see now. It has a space when you are still in the form typing the
subject. I will work on that now and post back when I think I have it
working.

Thanks!

Path: eternal-september.org!news.eternal-september.org!feeder2.eternal-september.org!i2pn.org!i2pn2.org!.POSTED!not-for-mail
From: retroguy@novabbs.org (Retro Guy)
Newsgroups: rocksolid.nodes.help
Subject: Re: spaces inserted when changing subject
Date: Mon, 25 Nov 2024 11:57:42 -0000 (UTC)
Organization: i2pn2 (i2pn.org)
Message-ID: <24a38f4d21942d5ed1d901936b29b7bd32f3ef4d@i2pn2.org>
References: <vgg4ei$26e09$1@dont-email.me> <c231a294be5371cfa1581d8e04e6907e$1@novabbs.org> <0b61c7ec2420f93fe1bb66604ecef6d5@example.com> <7b957ce7c199d3e5a5e7ae453587e8b1@www.novabbs.org> <761467a60ed7f0200610a7437de1a874@pi-dach.dorfdsl.de> <8c002ebc3ed7e50f8e128762c02d06cd@www.novabbs.org> <c6900d272a28fa4c496f8627e3d557c0@pi-dach.dorfdsl.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Injection-Date: Mon, 25 Nov 2024 11:57:42 -0000 (UTC)
Injection-Info: i2pn2.org;
logging-data="4060448"; mail-complaints-to="usenet@i2pn2.org";
posting-account="Gg8gAsZLN5FnWZrpbmz42d6ib2C2ewfwYI9Q557pxrY";
User-Agent: XPN/1.2.6 (Street Spirit ; Windows)
X-Spam-Checker-Version: SpamAssassin 4.0.0

View all headers

Ulf_Kutzner wrote:

I think I have it fixed. If you have time, please give it a try here:
https://news.novabbs.org/rocksolid/article-flat.php?id=4252&group=rocksolid.shared.test#4252

If it's ok, I'll let Marco know the one line to change in post.php if he
wishes to.

Thanks again!

Path: eternal-september.org!news.eternal-september.org!feeder2.eternal-september.org!i2pn.org!i2pn2.org!.POSTED!not-for-mail
From: retroguy@novabbs.com (Retro Guy)
Newsgroups: rocksolid.nodes.help
Subject: Re: spaces inserted when changing subject
Date: Mon, 25 Nov 2024 12:33:56 +0000
Organization: Rocksolid Light
Message-ID: <6d8592cc7141ffa4f9b5978f6e6b7db3@www.novabbs.org>
References: <vgg4ei$26e09$1@dont-email.me> <c231a294be5371cfa1581d8e04e6907e$1@novabbs.org> <0b61c7ec2420f93fe1bb66604ecef6d5@example.com> <7b957ce7c199d3e5a5e7ae453587e8b1@www.novabbs.org> <761467a60ed7f0200610a7437de1a874@pi-dach.dorfdsl.de> <8c002ebc3ed7e50f8e128762c02d06cd@www.novabbs.org> <c6900d272a28fa4c496f8627e3d557c0@pi-dach.dorfdsl.de> <24a38f4d21942d5ed1d901936b29b7bd32f3ef4d@i2pn2.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Injection-Info: i2pn2.org;
logging-data="4064989"; mail-complaints-to="usenet@i2pn2.org";
posting-account="HNchV9coSOli+kkOHciCZlGs2VaRn7Emh38jWV1k174";
User-Agent: Rocksolid Light
X-Rslight-Site: $2y$10$gtEPMkPT9Lur5p.SV3GWYueLpQUXbhWetBqgGwWYyjRrTTVHbCEqK
X-Rslight-Posting-User: 28547bffeec402cc2e544e2f8e28cc9329f66434
X-Face: .&YR-G(w(DZ$$,}%k=]*5*!p'=(anr"IT`wZG'2VWdfl\r)l[42u7JH`n(JUQ*e5*A|XCDf ?&\X&uwkl38"CYX3O8m}C8E4p'%N$2#kSTVzx{Ly|DjLT\Vk7NE}NQ(VC$Yq]i:7|z[.9iv^g>*8_B H0=hZt'[%)4kG|
X-Spam-Checker-Version: SpamAssassin 4.0.0

View all headers

On Mon, 25 Nov 2024 11:57:42 +0000, Retro Guy wrote:

> Ulf_Kutzner wrote:
>
>> On Mon, 25 Nov 2024 11:01:15 +0000, Retro Guy wrote:
>>
>>> On Mon, 25 Nov 2024 10:00:33 +0000, Ulf_Kutzner wrote:
>>>
>>>> On Thu, 7 Nov 2024 13:39:48 +0000, Retro Guy wrote:
>>>>
>>>>> On Wed, 6 Nov 2024 16:37:06 +0000, Retro Guy wrote:
>>>>>
>>>>>> On Wed, 6 Nov 2024 16:20:25 +0000, Retro Guy wrote:
>>>>>>
>>>>>>> On Wed, 6 Nov 2024 17:10:58 +0100, Marco Moock wrote:
>>>>>>>
>>>>>>>> Hello!
>>>>>>>>
>>>>>>>> One of my users reported that a space is inserted when changing the
>>>>>>>> subject.
>>>>>>>> https://pi-dach.dorfdsl.de/rocksolid/article-flat.php?id=209&group=rocksolid.shared.test#209
>>>>>>>>
>>>>>>>> Betreff 3 (war: Betreff 2? )
>>>>>>>>
>>>>>>>> According to him, it happens when replying to a post with changed
>>>>>>>> subject.
>>>>>>>>
>>>>>>>> If you need more info, please tell me.
>>>>>>>
>>>>>>> I think I see. Are they added at the end of the Subject?
>>>>>>>
>>>>>>> If so, I should be able to trim that, just let me know if that is the
>>>>>>> specific place you're seeing spaces added.
>>>>>>
>>>>>> Take a look in post.php (in <webdir>/rocksolid. Find line 64, or near
>>>>>> there:
>>>>>>
>>>>>> // Check some header strings for bad characters
>>>>>> $newsgroups = sanitize_header($newsgroups);
>>>>>> $subject = sanitize_header($subject);
>>>>>> $email = sanitize_header($email);
>>>>>>
>>>>>> change line:
>>>>>> $subject = sanitize_header($subject);
>>>>>>
>>>>>> to:
>>>>>> $subject = trim(sanitize_header($subject));
>>>>>>
>>>>>> and see if that fixes the issue.
>>>>>
>>>>> I have pushed this change to devel.
>>>>
>>>> Problem found again today while answering to
>>>> https://pi-dach.dorfdsl.de/rocksolid/article-flat.php?id=209&group=de.etc.bahn.stadtverkehr#209
>>>>
>>>> Had been resolved, has re-appered again?
>>>>
>>>> The space has, of course, been inserted before
>>>> but should be deleted while deleting the old
>>>> subject (the part in brackets which the space precedes).
>>>
>>> Is this the article where you are seeing the space:
>>> https://pi-dach.dorfdsl.de/rocksolid/article-flat.php?id=210&group=de.etc.bahn.stadtverkehr#210
>>>
>>> If so, I'm not seeing it. I checked the code and the "fix" is still
>>> there, at least in git. I viewed on the site you reference and do not
>>> see the space.
>>>
>>> What am I missing?
>>
>> What happens if you try to reply to
>>
>> Re: Strassenbahnzuege (war: Brueckeneinsturz)
>> From: Ignatios Souvatzis
>> Date: Sun, 24 Nov 2024 22:27 00100
>> Newsgroups: de.etc.bahn.stadtverkehr
>>
>> and while changing the subject again,
>> put the current subject into brackets again?
>
> I think I have it fixed. If you have time, please give it a try here:
> https://news.novabbs.org/rocksolid/article-flat.php?id=4252&group=rocksolid.shared.test#4252
>
> If it's ok, I'll let Marco know the one line to change in post.php if he
> wishes to.

Sounds like it's working now. Here's what is changed, it's just one line
in <webdir>/rocksolid/post.php (line 535 or near):

Change: echo ' value="' . htmlspecialchars($subject) . '" ';
To: echo ' value="' . trim(htmlspecialchars($subject)) . '" ';

That should do it. It will be in devel later today.

--
Retro Guy

BOFH excuse #444: overflow error in /dev/null

rocksolid / Rocksolid Nodes Help / Re: spaces inserted when changing subject

Subject	Author
spaces inserted when changing subject	Marco Moock
Re: spaces inserted when changing subject	Retro Guy
Re: spaces inserted when changing subject	Retro Guy
Re: spaces inserted when changing subject	Retro Guy
Re: spaces inserted when changing subject	Ulf_Kutzner
Re: spaces inserted when changing subject	Retro Guy
Re: spaces inserted when changing subject	Ulf_Kutzner
Re: spaces inserted when changing subject	Retro Guy
Re: spaces inserted when changing subject	Retro Guy
Re: spaces inserted when changing subject	Retro Guy